Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scala] Compile cucumber-scala_2.12 against Java 8 #1171

Merged
merged 2 commits into from
Jul 9, 2017
Merged

[Scala] Compile cucumber-scala_2.12 against Java 8 #1171

merged 2 commits into from
Jul 9, 2017

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jul 7, 2017 •
edited
Loading

Summary

Fix cucumber-scala_2.12 compatibility with Scala 2.12.

Details

  • cucumber-scala_2.12 is compiled as Java 8 bytecode, along with scala-calculator
  • Scala versions have been upgraded
    • 2.12.0-M1 to 2.12.2
    • 2.11.8 to 2.11.11
  • Use Manifest instead of Java reflection to provide type information

Motivation and Context

Issue #1087, #1091

How Has This Been Tested?

Existing tests and Scala example passing.

Manually tested against szarnyasg/cucumber-scala-2-12.
The expected result is that the test runs but fails.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Todo:

@mpkorstanje mpkorstanje mentioned this pull request Jul 7, 2017
Closed
6 tasks
@mpkorstanje mpkorstanje mentioned this pull request Jul 7, 2017
Closed
@mpkorstanje mpkorstanje changed the title [Scala] Work with java 8 [Scala] Compile Scala 2.12 against Java 8 Jul 7, 2017
@mpkorstanje mpkorstanje changed the title [Scala] Compile Scala 2.12 against Java 8 [Scala] Compile cucumber-scala_2.12 against Java 8 Jul 7, 2017
@mpkorstanje mpkorstanje added this to the 2.0.0 milestone Jul 7, 2017
@mpkorstanje
[Scala] Compile cucumber-scala_2.12 against java8
99557a0 
 - cucumber-scala_2.12 and scala-calculator are compiled to java8 byte code
 - Scala versions have been updated
   - 2.12.0-M1 to 2.12.2
   - 2.11.8    to 2.11.11
 - Manifest is used instead of Java reflection to provide type information

Related issues:
 - #1087
 - #1091

Fixes #1087
@mpkorstanje mpkorstanje merged commit e8d2d90 into master Jul 9, 2017
@mpkorstanje mpkorstanje deleted the scala-java-8 branch July 9, 2017 14:22
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mpkorstanje