Reduce Throwable to Exception in JavaSnippet #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are allowed to fail by throwing an(y) exception. As such #318 added `throws Throwable` to the JavaSnippet. Aside from being a bad practice this results in unnecessary checkstyle warnings. As such the generated snippet should not explicitly declare `Throwable`. Reducing `Throwable` to `Exception` should be sufficient. Fixes #1207
brasmusson
added a commit
that referenced
this pull request
Aug 29, 2017
brasmusson
reviewed
Aug 29, 2017
| @@ -2,6 +2,7 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO | |||
|
|
|||
| ## [2.0.0-SNAPSHOT](https://github.com/cucumber/cucumber-jvm/compare/v1.2.5...master) (In Git) | |||
|
|
|||
| * [Java] Reduce Throwable to Exception in JavaSnippet ([#1207](https://github.com/cucumber/cucumber-jvm/issues/1207), [#1208](https://github.com/cucumber/cucumber-jvm/pull/1208) M.P. Korstanje) | |||
There was a problem hiding this comment.
AFAIK, we discourage updating the Changelog in PR:s, and instead put that task on the person merging the PR.
There was a problem hiding this comment.
Planned on doing that myself. Then realized @mlvandijk could do it as a practice.
There was a problem hiding this comment.
Unfortunately, the same day I was up to release Cucumber-JVM 2.0.0 was the wrong day for such practice ...
There was a problem hiding this comment.
Such is life. :D
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests are allowed to fail by throwing an(y) exception. As such #318
added
throws Throwableto the JavaSnippet. Aside from being a badpractice this results in unnecessary checkstyle warnings. As such the
generated snippet should not explicitly declare
Throwable.Reducing
ThrowabletoExceptionshould be sufficient.Fixes #1207
How Has This Been Tested?
Updated the Unit Tests.
Types of changes
Checklist: