Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom javadoc.css #1212

Merged
merged 1 commit into from
Sep 4, 2017
Merged

Remove custom javadoc.css #1212

merged 1 commit into from
Sep 4, 2017

Conversation

mlvandijk
Copy link
Member

Summary

Fix Javadoc stylesheet issue #796

Details

Custom javadoc.css doesn't show menu properly.
Replacing with standard stylesheet.css for javadoc fixes this problem.

Motivation and Context

Create readable javadocs with proper navigation

How Has This Been Tested?

  • Generate javadoc locally using command 'mvn javadoc:aggregate'.
  • Open generated index.html in browser.
  • Environment:
    Version used: Current master
    Operating System and version: OS X, Sierra 10.12.6
    SDK 1.8 (1.8.0_121)
    • Chrome - Version 60.0.3112.113 (Official Build) (64-bit)
    • Firefox - 55.0.3 (64-bit)
    • Safari - Version 10.1.2 (12603.3.8)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.198% when pulling 1ac5fc0 on mlvandijk:javadoc-css into 80ba26c on cucumber:master.

@mlvandijk mlvandijk closed this Aug 30, 2017
@mlvandijk mlvandijk reopened this Aug 30, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.198% when pulling 1ac5fc0 on mlvandijk:javadoc-css into 80ba26c on cucumber:master.

@mpkorstanje
Copy link
Contributor

I think this can be accomplished without adding a new css file. In general you want to remove any files from the project that don't contribute anything.

Have a look at Configuring Stylesheets.

@mlvandijk
Copy link
Member Author

Good point. Updated the PR (incl rebase master).

@mlvandijk mlvandijk changed the title Replace custom javadoc.css with standard stylesheet.css for javadoc Remove custom javadoc.css Aug 31, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.198% when pulling d1ea961 on mlvandijk:javadoc-css into 8efe6e7 on cucumber:master.

@mpkorstanje mpkorstanje merged commit 953b5a3 into cucumber:master Sep 4, 2017
@mlvandijk mlvandijk deleted the javadoc-css branch September 16, 2017 18:22
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants