Fix spring transaction support and correct the transaction hook location in the example spring-txn #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make an ugly hack in the SpringFactory to apply the same spring context to SpringTransactionHooks as the step definition classes. Make sure search.feature in examples/spring-txn fails if not executed in a transaction. Remove @TxN annotation from see_messages.feature in examples/spring-txn, since it cannot run in transaction.
brasmusson
changed the title
|
I've added a "hack" to make the spring transaction support work. It is hardly the proper spring way to do it, but it works (as far as I can tell). |
|
If you can, please join here Mon, May 12, 3:00 PM - 4:00 PM to discuss: https://plus.google.com/u/0/events/cstdgkbvp61g7gld8lejsap4j3o |
|
Superseded by #711. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glue path in
@CucumberOptionannotation of the RunCukesTest in the spring transaction example, was not updated when the SpringTransactionHook class was moved from cucumber.runtime.java.spring.hooks to cucumber.api.spring. Therefore the example is currently actually a "spring-without-transactions-example".The root cause is that there will be two separate spring contexts, one based on
cucumber/runtime/java/spring/cucumber-glue.xml, and one based one the@ContextConfiguration("<cucumber.xml>")annotation. SpringTransactionHooks will be in the first context, and the step definition class (with the@ContextConfigurationannotation) and the application under test will be in the second context.A "hack" to make the spring transaction support work is to let the cucumber.runtime.java.spring.SpringFactory "detect" the
@ContextConfigurationannotation on the step definition classes and apply that configuration also to the SpringTransactionHooksFixes #637.