Correct JUnit notification for background steps #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The background steps are copied in the ExecutionUnitRunner for each scenario in a feature with background. This is done to make them unique for each scenario, so that the JUnit notification later will not be ambiguous. When the background steps are executed, it is the original ones that are executed. Therefore the background steps need to be 'converted' from the original steps to the copies made earlier, when performing the actual JUnit notifications for an execution unit (scenario).
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background steps are copied in the ExecutionUnitRunner for each scenario in a feature with background. This is done to make them unique for each scenario, so that the JUnit notification later will not be ambiguous. When the background steps are executed, it is the original ones that are executed. If the background steps are not 'converted' from the original steps to the copies made earlier, when performing the actual JUnit notifications for an execution unit (scenario), then the background step appear as Unrooted test in the Eclipse JUnit tab:
This PR change the JUnitReporter to use the steps copied, and now stored, in the ExecutionUnitRunner, as base for the JUnit notification. Then the background steps appear correctly in the Eclipse JUnit tab:
Fixes: #659.