Spring transactions still not working #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the first class found with spring annotation, to create the TestContextManagers for all glue classes.
Also remove the @TxN annotation from see_message.feature, since it fails if transactions are used.
Test that if a step def class autowires another step def class that has not been used yet. Then it is the instance that was autowired that are returned to the backend, when asked for an instance.
Let the SpringFactory register the bean definitions of the glue classes in the bean factory of TestContextManager's context. Use this bean factoryto create the instances of the glue classes. Alse register the GlueCodeScope in bean factory of the TestContextManager's context.
Make sure that glue classes with different @ContextConfiguration/ @ContextHierarchy annotations are defined in different packages (since the SpringFactory will throw an exception if glue classes are added with @ContextConfiguration/@ContextHierarchy annotations that are not equal).
…rasmusson/cucumber-jvm into brasmusson-spring-stepdef-injection-error
cd examples/spring-txn && mvn clean test && mvn test
|
False alarm. Transactions seem to be working after all: |
|
Hopefully they do ;-) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #711 I have made a small change that demonstrates how transactions are still not working properly.
The 2nd time tests are run they will fail. To trigger this I made the database file based instead of in-memory so that records from the previous run are left in the database.