Look at the artifacts name, rather than the project name, to detect c…

…ollisions

The artifact names are obtained from "moduleName", which may be different
from the project name. Fixes lightbend-labs#188

metadata/src/main/scala/com/typesafe/dbuild/model/RepeatableBuild.scala

@@ -131,7 +131,13 @@ case class RepeatableDBuildConfig(builds: Seq[ProjectConfigAndExtracted]) {
     // more appropriate to print the actual subproject name, rather than the Project
     case class Origin(fromProject: String, spaces: SeqString)
     case class Info(artOrg: String, artName: String, origin: Origin)
-    val generatedArtifacts = builds flatMap { b => b.extracted.projects.map { a => Info(a.organization, a.name, Origin(b.config.name, b.getSpace.to)) } }
+
+    // declare a collision if any artifacts in two distint projects have same organization and name
+    // (even if they differ in their extension or classifiers)
+    val generatedArtifacts = builds flatMap { b => b.extracted.projects.flatMap { _.artifacts.groupBy {
+      case ProjectRef(name, org, ext, classifier) => (org, name)
+    }.map { case ((org, name), _) => Info(org, name, Origin(b.config.name, b.getSpace.to)) } } }
+
     val byArt = (generatedArtifacts.groupBy { case Info(org, name, origin) => (org, name) }).toSeq
     val collisions = byArt flatMap {
       case ((org, name), seqInfo) =>