✨ feat(app): introduce allowList for custom components #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huynhducduy
commented
Nov 30, 2024
| @@ -53,6 +53,21 @@ With this configuration, the "style" attribute is ignored for native elements fo | |||
| } | |||
| ``` | |||
|
|
|||
| As of v3.4.0, each eslint-plugin-react-perf rule supports configuration to control whether custom component's props are ignored. | |||
There was a problem hiding this comment.
Please remember to change the version (v3.4.0) to your desired one
cvazac
reviewed
Jan 7, 2025
lib/utils/common.js
Outdated
| const { nativeAllowList } = options[0] || {}; | ||
| const { nativeAllowList, allowList } = options[0] || {}; | ||
|
|
||
| const allowListSet = new Set(); |
There was a problem hiding this comment.
const allowListSet = new Set(allowList || []);
|
Thanks for working on this @huynhducduy, this is a really great addition. If/when we support allowing component by name, we can name that param |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowListlikenativeAllowListthat allows all custom nodes to have allowed exceptions. #43