Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL+W does not work with 9.0 RC #1667

Closed
PoloniumRain opened this issue Oct 9, 2023 · 4 comments
Closed

CTRL+W does not work with 9.0 RC #1667

PoloniumRain opened this issue Oct 9, 2023 · 4 comments

Comments

@PoloniumRain
Copy link

PoloniumRain commented Oct 9, 2023

System information:

  • Windows OS version: 10 Pro
  • ImageGlass version: 9.0 RC with .NET 8

To Reproduce

Steps to reproduce the behavior:

  1. Open IG
  2. Press CTRL+W keys
  3. IG will not close

IG 9.0 RC no longer closes when pressing the CTRL+W keys. This works in previous releases. I'm assuming this is a bug or just a feature that is not implement yet?

And as some general feedback, overall i'm really liking 9.0 RC. It's a clear improvement over all previous versions. It fixes a LOT of the main issues i've had with IG for many years, especially when it comes to performance. Some areas where the Windows Photos app had a very obvious performance advantage over IG were with things like loading very high res images, certain file types, zooming in/out, going to the next/previous image, and panning/moving images (especially when using bicubic interpolation). Basic everyday tasks yet IG was always far behind. With IG 9.0 the gap has been greatly reduced and in some cases it's just as fast. Great work :)

@d2phap
Copy link
Owner

d2phap commented Oct 10, 2023

Hotkeys are reworked in v9 for customization support.
You can edit the igconfig.json to add Ctrl+W hotkey for closing IG:

// in igconfig.json
{
  "MenuHotkeys": {
    "MnuExit": ["Escape", "Ctrl+W"]
  }
}

No setting UI for this yet because. Make sure you close IG before editing the igconfig.json.

@PoloniumRain
Copy link
Author

Thanks that works well.

Will this eventually be the default setting? Because even if it will be customisable i still think that CTRL+W should be default because it's so commonly used. I even have one of my mouse buttons mapped to CTRL+W.

@d2phap d2phap added this to the v9.0 GA milestone Oct 22, 2023
d2phap added a commit that referenced this issue Oct 22, 2023
@d2phap
Copy link
Owner

d2phap commented Oct 23, 2023

I will add it together with ESC as default hotkeys to close the app

@d2phap d2phap added the v9.0 label Nov 4, 2023
@d2phap
Copy link
Owner

d2phap commented Nov 24, 2023

Fixed in ImageGlass 9.0.7.1125

@d2phap d2phap closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants