Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link in image interpolation settings to more info #1982

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

stevencaiOR
Copy link
Contributor

The base language file and all language JSON files were updated to include variables FrmSettings._ImageInterpolation._MoreInfo and FrmSettings._ImageInterpolation._MoreInfoLink. FrmSettings._ImageInterpolation._MoreInfo was set to “More Info” in all languages, as I am unfamiliar with foreign languages. FrmSettings._ImageInterpolation._MoreInfoLink was set to a Microsoft’s web page on interpolation modes, with the corresponding language set in the URL.

In the FrmSettings.html, I added an <a> element which contained lang-text and lang-href attributes set to FrmSettings._ImageInterpolation._MoreInfo and FrmSettings._ImageInterpolation._MoreInfoLink respectively.

Since there was no way to process lang-href, I also added a function call to Language.ts which processed lang-href attribute and updated href dynamically.

@d2phap d2phap merged commit 791a129 into d2phap:develop Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants