preattentive symbols #189
Merged
preattentive symbols #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbols with preattentive features aid pattern detection and reduce overlap. This symbol set implements ideas of Cleveland, Wilkinson, and others, and has been tested for popularity and discriminability, and adjusted for approximately equal weight. Many products support up to a dozen different symbol sets. This is analogous to multiple color schemes, such as Dr. Cindy Brewer's recently supported in d3. Not knowing d3's plans for symbol sets, I've only made a bare attempt at integrating these, but would be happy to continue this work along whatever lines are appropriate.
Closed
Fil
approved these changes
Jan 6, 2022
Fil
approved these changes
Jan 7, 2022
Co-authored-by: Philippe Rivière <fil@rezo.net>
Co-authored-by: Philippe Rivière <fil@rezo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #176. I adjusted the implementations proposed by @hemanrobinson for style, and to fit empirically the behavior of symbolCircle when using a stroke width of 1.5px and round line caps. (See notebook.) I also updated some old D3 code for modern JavaScript style. Adds the following new symbols:
In addition, adds two new sets of symbols:
The symbolsFill is equivalent to and replaces symbols, which is now deprecated.
I considered the following alternative names:
Ultimately I don’t think the names matter too much as I expect most often the symbols will be chosen automatically automatically by Plot (using symbolsStroke—though we could perhaps make Plot smart enough to chose symbolsStroke or SymbolsFill depending on whether a fill or stroke channel is present).
TODO