feat(define-router): handleApi #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tylersayshi
approved these changes
Dec 28, 2024
| staticElementIds?: SlotId[]; | ||
| noSsr?: true; | ||
| is404?: true; | ||
| isApi?: true; |
There was a problem hiding this comment.
Do we still plan to have getApiConfig separate from getRouteConfig?
Including isApi here makes it seem like we'll use this type for both kinds of configs, api and route.
Or is this just temporary and getApiConfig will come later?
There was a problem hiding this comment.
It is an internal implementation detail. The define-router users won't see it. Yeah, I think separating them would be good. They have different configs and I would like to pair getFooConfig and handleFoo.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.