-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): configuration of scroll behavior for Link and useRouter #1231
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@dai-shi all very true. I didn't give the api enough though. How about something like this: /**
* Indicates that the link should not scroll when clicked. By default, waku will
* scroll when the path changes. This is a way to explicitly not change the scroll
* position on navigation.
*/
dontScroll?: boolean; alternate names: Let me know what you think and I'll change the code accordingly |
@tylersayshi I'm afraid my comment wasn't very clear. I'm actually fine with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
follow up for: #1098 (comment)
cc @wesbos thanks for this call out