Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curve: add precomputation length #685

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

AaronFeickert
Copy link
Contributor

Adds functionality to VartimePrecomputedMultiscalarMul to return the number of points in the precomputation.

@AaronFeickert AaronFeickert force-pushed the precomp-len branch 3 times, most recently from 042ea16 to 9781bba Compare August 3, 2024 03:09
@AaronFeickert AaronFeickert force-pushed the precomp-len branch 2 times, most recently from 6f7001c to faf1f6d Compare January 3, 2025 18:27
@AaronFeickert
Copy link
Contributor Author

This has been updated to account for the changes in #695, and should be good to go.

@rozbb
Copy link
Contributor

rozbb commented Jan 4, 2025

LGTM! Can I ask, what was the motivation to add these methods?

@AaronFeickert
Copy link
Contributor Author

@rozbb: I was working on a project that used partial precomputation, and for which it would be useful to know the size of an existing precomputation table in order to determine if it was valid for a given use case.

@rozbb
Copy link
Contributor

rozbb commented Jan 5, 2025

Ah, ok, sounds good!

@rozbb rozbb requested review from rozbb and tarcieri January 5, 2025 00:10
@rozbb rozbb merged commit ed83542 into dalek-cryptography:main Jan 12, 2025
22 checks passed
@AaronFeickert AaronFeickert deleted the precomp-len branch January 12, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants