Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caption to wavarray and more dispatches #104

Merged
merged 2 commits into from
Jul 31, 2021

Conversation

rmsrosa
Copy link
Contributor

@rmsrosa rmsrosa commented Jul 4, 2021

This implements the caption for WAVArray to address and close #100

It also adds some dispatches to read WAVArray directly from io or from a filename.

A few tests were also added to test the new features.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2021

Codecov Report

Merging #104 (5eddfd3) into main (832182e) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   73.68%   74.05%   +0.37%     
==========================================
  Files           6        6              
  Lines         627      636       +9     
==========================================
+ Hits          462      471       +9     
  Misses        165      165              
Impacted Files Coverage Δ
src/AudioDisplay.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832182e...5eddfd3. Read the comment docs.

@dancasimiro dancasimiro merged commit 0dc24f6 into dancasimiro:main Jul 31, 2021
dancasimiro referenced this pull request Nov 28, 2021
This change adds the caption support to WAV array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caption for WAV display
3 participants