Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various alerts reported by LGTM #145

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Fix various alerts reported by LGTM #145

merged 1 commit into from
Jul 6, 2022

Conversation

danielealbano
Copy link
Owner

This PR fixes various alerts reported by LGTM to improve the overall code quality score

@danielealbano danielealbano added the bug Something isn't working label Jul 6, 2022
@danielealbano danielealbano added this to the v0.2 milestone Jul 6, 2022
@danielealbano danielealbano self-assigned this Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #145 (d3e6be5) into main (802524d) will increase coverage by 0.08%.
The diff coverage is 61.90%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   80.27%   80.35%   +0.08%     
==========================================
  Files          86       86              
  Lines        5180     5191      +11     
==========================================
+ Hits         4158     4171      +13     
+ Misses       1022     1020       -2     
Impacted Files Coverage Δ
src/protocol/redis/protocol_redis_reader.c 92.59% <ø> (-0.06%) ⬇️
src/worker/storage/worker_storage_iouring_op.c 87.50% <ø> (ø)
src/storage/db/storage_db.c 48.48% <50.00%> (+0.29%) ⬆️
src/worker/worker.c 81.13% <50.00%> (ø)
src/hugepage_cache.c 93.75% <100.00%> (ø)
src/protocol/redis/protocol_redis_writer.c 60.73% <100.00%> (-0.90%) ⬇️
src/spinlock.c 100.00% <100.00%> (ø)
src/storage/channel/storage_channel.c 100.00% <100.00%> (ø)
src/support/simple_file_io.c 92.30% <100.00%> (-7.70%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802524d...d3e6be5. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 6, 2022

This pull request fixes 16 alerts when merging d3e6be5 into 802524d - view on LGTM.com

fixed alerts:

  • 7 for Missing return statement
  • 4 for Expression has no effect
  • 3 for Comparison result is always the same
  • 2 for Duplicate include guard

@danielealbano danielealbano merged commit f59f690 into main Jul 6, 2022
@danielealbano danielealbano deleted the fix-lgtm-alerts branch July 6, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant