Implemented PSETEX command #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 80.31% // Head: 80.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 80.31% 80.33% +0.02%
==========================================
Files 132 133 +1
Lines 7993 8012 +19
==========================================
+ Hits 6419 6436 +17
- Misses 1574 1576 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
danielealbano
requested changes
Aug 31, 2022
| bool return_res = false; | ||
| bool key_and_value_owned = false; | ||
| module_redis_command_psetex_context_t *context = connection_context->command.context; | ||
|
|
There was a problem hiding this comment.
Add a check to valiate that the value passed in greater than 0, if not the following error has to be returned
ERR invalid expire time in 'psetex' command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.