Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 feat: Read NGINX Config and Cleanup Docker Images 🐳 #1211

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

danny-avila
Copy link
Owner

Summary

This update is aimed at refining the deployment process of our NGINX service by adjusting the volume mapping in the Docker Compose file to include the current NGINX configuration from the client directory. This ensures that users pulling the remote image get the latest configuration changes, addressing an issue where NGINX was not updating in all instances. The motivation behind this improvement is the recent addition of image uploads to the gpt-4-vision API, which necessitated an increase in the NGINX file upload limit from the default 1 MB. Alongside this, the update script has been enhanced to remove old Docker images, keeping the system lean and preventing accumulation of unused, amd most up-to-date images.

Change Type

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

Confirm that NGINX correctly uses the updated configuration and that the update script removes old Docker images as expected. The testing process involves:

  1. Deploying NGINX with the updated docker-compose.yml and verifying that the nginx.conf is correctly utilized.
    • I ran docker exec -it LibreChat-NGINX cat /etc/nginx/conf.d/default.conf before and after making local changes to the client/nginx.conf file, after seeing the changes I just made
  2. Testing the image upload feature of the gpt-4-vision API to ensure that files larger than 1 MB can be uploaded successfully.
  3. Running the update script and checking if old Docker images are properly removed without affecting running containers.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

Sorry, something went wrong.

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
…e script
@danny-avila danny-avila changed the title 🔧 feat: Enhance NGINX Config and Cleanup Docker Images 🐳 🔧 feat: Read NGINX Config and Cleanup Docker Images 🐳 Nov 23, 2023
@danny-avila danny-avila merged commit 6507593 into main Nov 23, 2023
@danny-avila danny-avila deleted the deployed-compose-update branch November 23, 2023 04:35
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant