Darwinia Spec 1101 #693

aurexav · 2021-07-29T09:23:51Z

Migrate DarwiniaEthereumBacking to EthereumBacking

^{Created from VS Code using CodeStream}

hackfisher · 2021-07-29T09:33:28Z

runtime/darwinia/src/lib.rs

+	use frame_support::migration;
+
+	log::info!("Moving storage `DarwiniaEthereumBacking` to `EthereumBacking`");
+	migration::move_pallet(b"DarwiniaEthereumBacking", b"EthereumBacking");


The event storage key in Ethereum smart contract for locking assets need be upgrade too. @hujw77 @WoeOm

aurexav · 2021-07-29T09:35:28Z

@wi1dcard

Is this name available?

docker pull quay.io/darwinia-network/darwinia:v0.11.0-fix-storage

wi1dcard · 2021-07-29T09:36:47Z

@wi1dcard

Is this name available?
docker pull quay.io/darwinia-network/darwinia:v0.11.0-fix-storage

Yes, it conforms to the name convention of docker images.

aurexav · 2021-07-29T09:38:22Z

Yes, it conforms to the name convention of docker images.

Where can I specify the name? In toml, README or somewhere.

wi1dcard · 2021-07-29T09:40:56Z

Where can I specify the name? In toml, README or somewhere.

Just create a tag named v0.11.0-fix-storage. Or if you'd like to have a tag with a different name, please let me know after the tag has been created and I will manually push the docker images.

aurexav · 2021-07-29T09:41:54Z

Just create a tag named v0.11.0-fix-storage. Or if you'd like to have a tag with a different name, please let me know after the tag has been created and I will manually push the docker images.

Great, I'll create a tag named v0.11.0-fix-storage directly.

hackfisher · 2021-07-29T09:43:39Z

If between 1100 and 1101, some one send transaction and write some storage in the same value or map key, will the migrate overwrite. Will it abort due to there are already exist?

aurexav · 2021-07-29T09:44:47Z

Try Runtime

Click to expand!

2021-07-29 17:41:01 `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0
2021-07-29 17:41:01 [#0] 🗳  Finalized election round with compute ElectionCompute::OnChain.
2021-07-29 17:41:01 [0] 💸 new validator set of size 1 has been processed for era 1
2021-07-29 17:41:01 initializing remote client to "http://localhost:20000"
2021-07-29 17:41:01 scraping keypairs from remote node http://localhost:20000 @ 0x59603ed330fa54b728809fe130ee783dbcff169c91d27fc31c29c85b59d79136
2021-07-29 17:41:01 downloading data for all modules.
2021-07-29 17:41:36 extending externalities with 1 manually injected keys
2021-07-29 17:41:36 injecting a total of 98188 keys
2021-07-29 17:41:38 try-runtime::on_runtime_upgrade Darwinia.
2021-07-29 17:41:38 Moving storage `DarwiniaEthereumBacking` to `EthereumBacking`
2021-07-29 17:41:38 ⚠️ System declares internal migrations (which *might* execute), setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 Moving storage `DarwiniaEthereumBacking` to `EthereumBacking`
2021-07-29 17:41:38 ✅ no migration for TronBacking, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for EthereumRelayAuthorities, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for EthereumRelayerGame, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for EthereumBacking, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for EthereumRelay, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for CrabBacking, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Multisig, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Proxy, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Scheduler, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Recovery, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Society, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Identity, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Utility, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Vesting, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Sudo, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Treasury, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for TechnicalMembership, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for PhragmenElection, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for TechnicalCommittee, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Council, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Democracy, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for DarwiniaHeaderMMR, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for AuthorityDiscovery, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for ImOnline, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Grandpa, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Session, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Historical, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Offences, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Staking, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for ElectionProviderMultiPhase, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Authorship, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for TransactionPayment, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Kton, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Balances, setting storage version to PalletVersion { major: 2, minor: 3, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Timestamp, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for Babe, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 ✅ no migration for RandomnessCollectiveFlip, setting storage version to PalletVersion { major: 3, minor: 0, patch: 0 }
2021-07-29 17:41:38 try-runtime executed without errors. Consumed weight = 512972800000000, total weight = 512000000000000 (1.0019)

CHANGELOG.md

aurexav · 2021-07-29T09:49:24Z

If between 1100 and 1101, some one send transaction and write some storage in the same value or map key, will the migrate overwrite. Will it abort due to there are already exist?

Yes. It will be overwritten. But I didn't find any extrinsic could execute successfully. Except lock. But the LockAssetEvent storage will be cleared each block. So it's okay.

hackfisher · 2021-07-29T10:28:56Z

https://darwinia.subscan.io/extrinsic/4352896-1

* add logs * update crates version * update runtime version * merge `CHANGELOG` from #693 * update `CHANGELOG`

Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.30 to 1.0.31. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.30...1.0.31) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Xavier Lau added 2 commits July 29, 2021 17:12

update darwinia spec_version to 1101

a870d0d

migrate DarwiniaEthereumBacking to EthereumBacking

00b4722

aurexav added the Darwinia label Jul 29, 2021

aurexav marked this pull request as draft July 29, 2021 09:24

aurexav added Migration Added labels Jul 29, 2021

sync CHANGELOG

ac68a82

hackfisher reviewed Jul 29, 2021

View reviewed changes

update CHANGELOG

bb2b9ce

aurexav marked this pull request as ready for review July 29, 2021 09:35

hackfisher reviewed Jul 29, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

e096782

hackfisher merged commit b4440e2 into v0.11.0-fork Jul 29, 2021

hackfisher deleted the xavier-migrate branch July 29, 2021 09:48

aurexav pushed a commit that referenced this pull request Aug 3, 2021

merge CHANGELOG from #693

f2d63bb

aurexav pushed a commit that referenced this pull request Aug 3, 2021

Tag v0.11.2 (#698)

a01a39e

* add logs * update crates version * update runtime version * merge `CHANGELOG` from #693 * update `CHANGELOG`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Darwinia Spec 1101 #693

Darwinia Spec 1101 #693

aurexav commented Jul 29, 2021

hackfisher Jul 29, 2021

aurexav commented Jul 29, 2021

wi1dcard commented Jul 29, 2021

aurexav commented Jul 29, 2021 •

edited

Loading

wi1dcard commented Jul 29, 2021

aurexav commented Jul 29, 2021

hackfisher commented Jul 29, 2021 •

edited

Loading

aurexav commented Jul 29, 2021

aurexav commented Jul 29, 2021 •

edited

Loading

hackfisher commented Jul 29, 2021

Darwinia Spec 1101 #693

Darwinia Spec 1101 #693

Conversation

aurexav commented Jul 29, 2021

hackfisher Jul 29, 2021

Choose a reason for hiding this comment

aurexav commented Jul 29, 2021

wi1dcard commented Jul 29, 2021

aurexav commented Jul 29, 2021 • edited Loading

wi1dcard commented Jul 29, 2021

aurexav commented Jul 29, 2021

hackfisher commented Jul 29, 2021 • edited Loading

aurexav commented Jul 29, 2021

aurexav commented Jul 29, 2021 • edited Loading

hackfisher commented Jul 29, 2021

aurexav commented Jul 29, 2021 •

edited

Loading

hackfisher commented Jul 29, 2021 •

edited

Loading

aurexav commented Jul 29, 2021 •

edited

Loading