Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: ARM releases can now be done on Github runners. #184

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

ktechmidas
Copy link
Contributor

@ktechmidas ktechmidas commented Feb 5, 2025

  • Changed to Github ARM runners
  • Fixed small issue where the protoc was skipped during presetup

Summary by CodeRabbit

  • Chores
    • Enhanced the ARM64 build process by specifying a more stable deployment environment.
    • Refined the conditions for platform-specific tool installation to improve overall build reliability.

Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

This pull request updates the release workflow configuration for the Dash Evo Tool. In the ARM64 job configuration, the runs-on attribute has been changed to a specific runner (ubuntu-22.04-arm). Additionally, the conditional check for installing the protoc tool is now based on arm64-linux rather than arm64, which refines the control flow of the workflow without altering its overall structure.

Changes

File Change Summary
.github/workflows/release.yml Updated ARM64 job configuration: changed runs-on from an array (["self-hosted", "Linux", "ARM64", "ubuntu20.04"]) to ubuntu-22.04-arm, and modified the conditional check for the protoc installation step from matrix.platform == 'arm64' to matrix.platform == 'arm64-linux'.

Sequence Diagram(s)

sequenceDiagram
    participant Repo as Git Repository
    participant GH as GitHub Actions
    participant Runner as ubuntu-22.04-arm Runner
    participant Checker as Condition Checker
    participant Protoc as Protoc Installer

    Repo->>GH: Trigger release workflow
    GH->>Runner: Dispatch ARM64 job
    Runner->>GH: Begin job execution
    GH->>Checker: Evaluate if condition (matrix.platform == 'arm64-linux')
    alt Condition True
        Checker->>Protoc: Execute protoc installation step
    else Condition False
        Checker->>Runner: Skip protoc installation
    end
Loading

Possibly related PRs

  • release: provide zip for release #19: Addresses ARM64 platform configuration modifications, specifically updating platform identifiers and installation steps relevant to the ARM64 build process.

Suggested reviewers

  • QuantumExplorer

Poem

Hoppin' through lines of code so bright,
I found a tweak that feels just right.
ARM64 leaps on Ubuntu’s ground,
Conditions refined with a cheerful sound.
I, the rabbit, celebrate with delight!
🐇 Happy to see our builds take flight!
Cheers to the journey in code, day and night!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df64f73 and 71701d7.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (2 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/release.yml

33-33: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

🔇 Additional comments (2)
.github/workflows/release.yml (2)

32-35: Runner Label 'ubuntu-22.04-arm': Validate Custom Label Usage

The runs-on value for the "linux-arm64" job is now set to "ubuntu-22.04-arm". However, static analysis (actionlint) indicates that this label is not among the standard options (e.g., "ubuntu-22.04" is available). Please verify that "ubuntu-22.04-arm" is a valid custom label configured for your GitHub ARM runners. If this label is intended for a self-hosted runner, ensure that your actionlint configuration is updated accordingly; otherwise, consider switching to a recognized GitHub-hosted runner label.

🧰 Tools
🪛 actionlint (1.7.4)

33-33: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)


85-87: Refined Conditional for ARM protoc Installation

The condition for the ARM-specific installation of protoc has been updated to:

if: ${{ matrix.platform == 'arm64-linux' }}

This change improves the clarity and precision of the conditional logic, ensuring that the installation step runs only for the ARM Linux configuration.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pauldelucia pauldelucia merged commit f8ad3b2 into master Feb 5, 2025
7 checks passed
@pauldelucia pauldelucia deleted the release-on-arm branch February 5, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants