Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zerossl condition check #508

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: zerossl condition check #508

merged 1 commit into from
May 18, 2023

Conversation

pshenmic
Copy link
Collaborator

Issue being fixed or feature implemented

Default value for dashmate_platform_dapi_envoy_ssl_provider_config_zerossl_api_key is null and check fails for nodes without this property set.

What was done?

Fixed check condition

How Has This Been Tested?

On the devnet

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic changed the base branch from v0.25-dev to master May 18, 2023 05:47
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 48456ae into master May 18, 2023
@shumkov shumkov deleted the fix/zerossl-api-check branch May 18, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants