Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hardcoded path to dashmate logs #509

Merged
merged 4 commits into from
Jun 13, 2023
Merged

fix: hardcoded path to dashmate logs #509

merged 4 commits into from
Jun 13, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 13, 2023

Issue being fixed or feature implemented

It's impossible to change correctly path dashmate logs, since the deploy playbook is using a hardcoded path.

What was done?

  • Define a variable on playbook level and use it in the playbook

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.24.x milestone Jun 13, 2023
@strophy strophy merged commit d9d923e into master Jun 13, 2023
@strophy strophy deleted the fix/use_variable branch June 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strophy strophy strophy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shumkov @strophy