Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused todo tasks #538

Merged
merged 1 commit into from
Sep 4, 2023
Merged

chore: remove unused todo tasks #538

merged 1 commit into from
Sep 4, 2023

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Aug 29, 2023

Issue being fixed or feature implemented

Commented todo tasks still existed for handling dashmate restarts and tenderdash configuration changes. Dashmate restarts now work properly, and the tenderdash configurations are apparently unused (right @shumkov?)

What was done?

Removed commented tasks

How Has This Been Tested?

Untested

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy changed the title chore: remove unused todo roles chore: remove unused todo tasks Aug 29, 2023
@ktechmidas
Copy link
Contributor

Why master?

@strophy strophy merged commit 0beea45 into master Sep 4, 2023
@strophy strophy deleted the chore/clean-up-todos branch September 4, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants