Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create tenderdash role for seed nodes #567

Merged
merged 16 commits into from
Sep 26, 2023
Merged

chore: create tenderdash role for seed nodes #567

merged 16 commits into from
Sep 26, 2023

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Sep 25, 2023

Issue being fixed or feature implemented

Seed nodes should no longer be deployed by dashmate

What was done?

Implement Tenderdash-only role in deploy tool

How Has This Been Tested?

On testnet seed-3

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.25.0 milestone Sep 25, 2023
@strophy strophy requested a review from shumkov September 25, 2023 05:29
@strophy strophy marked this pull request as ready for review September 25, 2023 05:56
@strophy strophy requested a review from ktechmidas September 25, 2023 05:56
ktechmidas
ktechmidas previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@ktechmidas ktechmidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shumkov
shumkov previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shumkov
shumkov requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use cheaper instances for seeds?

@strophy
Copy link
Collaborator Author

strophy commented Sep 25, 2023

OK, good idea. Please approve and I'll deploy this change tomorrow (will need to slowly restart all nodes with new seed IPs in config)

@strophy strophy merged commit 42d3868 into v0.25-dev Sep 26, 2023
@strophy strophy deleted the chore/seed-td-role branch September 26, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov requested changes

@ktechmidas ktechmidas ktechmidas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@strophy @shumkov @ktechmidas