Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alarm dimensions #587

Merged
merged 8 commits into from
Oct 18, 2023
Merged

fix: alarm dimensions #587

merged 8 commits into from
Oct 18, 2023

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Oct 17, 2023

Issue being fixed or feature implemented

Alarms were stuck in an "insufficient data" state because the dimensions they were configured with do not match the append_dimensions dimensions shipped by CWAgent

What was done?

  • Refactor local variables in monitoring.tf
  • Remove actions for insufficient_data and ok states
  • Align periods with metric delivery period
  • Use integers for numerical values

How Has This Been Tested?

On testnet

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy requested a review from ktechmidas October 17, 2023 02:55
ktechmidas
ktechmidas previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ktechmidas ktechmidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strophy
Copy link
Collaborator Author

strophy commented Oct 18, 2023

Needs #590

@strophy strophy requested a review from ktechmidas October 18, 2023 06:16
ktechmidas
ktechmidas approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ktechmidas ktechmidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strophy strophy merged commit f20461d into v0.25-dev Oct 18, 2023
@strophy strophy deleted the fix/alarm-dimensions branch October 18, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktechmidas ktechmidas ktechmidas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strophy @ktechmidas