Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable full text indexing on tenderdash errors #588

Merged
merged 3 commits into from
Oct 17, 2023
Merged

chore: enable full text indexing on tenderdash errors #588

merged 3 commits into from
Oct 17, 2023

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Oct 17, 2023

Issue being fixed or feature implemented

We need to be able to search by json.error in Tenderdash logs

What was done?

Enable full text indexing on json.error field

How Has This Been Tested?

Untested

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.25.0 milestone Oct 17, 2023
@strophy strophy requested a review from ktechmidas October 17, 2023 05:01
shumkov
shumkov approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strophy strophy merged commit 67214ca into v0.25-dev Oct 17, 2023
@strophy strophy deleted the fix/es-error-search branch October 17, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@ktechmidas ktechmidas Awaiting requested review from ktechmidas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@strophy @shumkov