Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate minimal dash.conf file in configs repo #593

Merged
merged 1 commit into from
Oct 23, 2023
Merged

feat: generate minimal dash.conf file in configs repo #593

merged 1 commit into from
Oct 23, 2023

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Oct 23, 2023

Issue being fixed or feature implemented

Devs often need a minimal dash.conf file for a network.

What was done?

Implement a role to generate dash.conf for the network.

How Has This Been Tested?

Locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.25.0 milestone Oct 23, 2023
@strophy strophy requested a review from ktechmidas October 23, 2023 03:48
ktechmidas
ktechmidas approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@ktechmidas ktechmidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strophy strophy merged commit 0b04ad7 into v0.25-dev Oct 23, 2023
@strophy strophy deleted the feat/gen-dash-conf branch October 23, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktechmidas ktechmidas ktechmidas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@strophy @ktechmidas