Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dashmate): add core.docker.commandArgs option #597

Merged
merged 1 commit into from
Nov 2, 2023
Merged

chore(dashmate): add core.docker.commandArgs option #597

merged 1 commit into from
Nov 2, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Nov 2, 2023 •
edited
Loading

Issue being fixed or feature implemented

Dashmate v0.29.9 requires core.docker.commandArgs option in the config.

What was done?

  • Added core.docker.commandArgs option to the dashmate template

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

pshenmic
pshenmic approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

ktechmidas
ktechmidas approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@ktechmidas ktechmidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shumkov shumkov added this to the v0.25.0 milestone Nov 2, 2023
@shumkov shumkov merged commit a3ba045 into v0.25-dev Nov 2, 2023
@shumkov shumkov deleted the chore/dashmate/add-command-args branch November 2, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktechmidas ktechmidas ktechmidas approved these changes

@pshenmic pshenmic pshenmic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shumkov @ktechmidas @pshenmic