Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drive abci custom loggers configuration #1487

Merged
merged 27 commits into from
Oct 16, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Oct 12, 2023

Issue being fixed or feature implemented

We need to log the grovedb operations on testnet so we can easily debug sources of non-determinism. Since grovedb operations contain a lot of data we don't want to push it to elastic. We need a separate file to write grovedb operations there. To allow such configuration, Dashmate should provide options to define custom Drive ABCI loggers.

What was done?

  • Allow to configure any number of loggers in Dashmate.
  • Accept a logging specification string (RUST_LOG) as logger level in Drive ABCI
  • Refactored logging module in Drive ABCI

New Drive's logs configuration format:

  • destination - stdout, stderr or file path
  • level - error, warn, info, debug, trace, silent or logging specification string in RUST_LOG format
  • format - full, compact, pretty, json
  • color - boolean or null (autodetect)

How Has This Been Tested?

With tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.25.x milestone Oct 12, 2023
@shumkov shumkov marked this pull request as ready for review October 12, 2023 16:49
@shumkov shumkov requested a review from lklimek October 12, 2023 17:03
lklimek
lklimek previously approved these changes Oct 16, 2023
@QuantumExplorer QuantumExplorer changed the base branch from master to v1.0-dev October 16, 2023 16:16
@QuantumExplorer QuantumExplorer dismissed lklimek’s stale review October 16, 2023 16:16

The base branch was changed.

@QuantumExplorer QuantumExplorer merged commit a847198 into v1.0-dev Oct 16, 2023
@QuantumExplorer QuantumExplorer deleted the feat/custom-loggers branch October 16, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants