refactor(ui/lineage): Replace FetchedEntities Object with Map #11440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jjoyce0510
reviewed
Sep 20, 2024
| fullyFetched, | ||
| }, | ||
| }; | ||
| const newFetchedEntities = new Map(fetchedEntities); |
jjoyce0510
reviewed
Sep 20, 2024
| @@ -71,10 +71,10 @@ export function convertInputFieldsToSchemaFields(inputFields?: InputFields) { | |||
| */ | |||
| export function getPopulatedColumnsByUrn( | |||
| columnsByUrn: Record<string, SchemaField[]>, | |||
| fetchedEntities: { [x: string]: FetchedEntity }, | |||
| fetchedEntities: Map<string, FetchedEntity>, | |||
There was a problem hiding this comment.
nice - okay change below i think would be safe if this is what is getting passed
jjoyce0510
approved these changes
Sep 20, 2024
jjoyce0510
reviewed
Sep 20, 2024
| @@ -77,12 +77,12 @@ export default function LineageExplorer({ urn, type }: Props) { | |||
|
|
|||
| const [isDrawerVisible, setIsDrawVisible] = useState(false); | |||
| const [selectedEntity, setSelectedEntity] = useState<EntitySelectParams | undefined>(undefined); | |||
| const [asyncEntities, setAsyncEntities] = useState<FetchedEntities>({}); | |||
| const [asyncEntities, setAsyncEntities] = useState<FetchedEntities>(new Map()); | |||
There was a problem hiding this comment.
Is the type here correct? Should this be
map<string, fetchedEntities>?
There was a problem hiding this comment.
These are equivalent: type FetchedEntities = Map<string, FetchedEntity>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist