Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): drop empty fields #11613

Merged
merged 3 commits into from
Oct 15, 2024
Merged

fix(ingest): drop empty fields #11613

merged 3 commits into from
Oct 15, 2024

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 14, 2024
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might've been better to rename auto_fix_duplicate_schema_field_paths -> auto_fix_schema_field_paths, and put this functionality in the same method

@anshbansal
Copy link
Collaborator Author

airflow failure is being fixed here #11616

@anshbansal
Copy link
Collaborator Author

testQuick passed but it is stuck for some reason. Happening in multiple PRs

So merging as not related to this PR

@anshbansal anshbansal merged commit 1eec2c4 into master Oct 15, 2024
71 of 73 checks passed
@anshbansal anshbansal deleted the ab-drop-empty-fields branch October 15, 2024 09:23
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@tkdrahn
Copy link
Contributor

tkdrahn commented Mar 5, 2025

I don’t believe we have that pulled into our ingestion code, will take a look.

It looks like that will just drop the field completely from the Schema, that’s not what we want either is it?

@hsheth2
Copy link
Collaborator

hsheth2 commented Mar 5, 2025

I’d like to understand the empty column name thing - we had assume that that wasn’t really a valid thing (and it also messes up our UI)

What’s the use case for it - eg how do you query a table/view with an empty column name?

@tkdrahn
Copy link
Contributor

tkdrahn commented Mar 5, 2025

I certainly wouldn’t do it but our catalog team doesn’t own the data sets we’re trying to ingest. We have a large number of Snowflake views at our company that have a column with a blank column name

here is an example Snowflake SQL to demonstrate:

create view example_view as ( select field1 as “”, field2 as “field2” from my_base_table);

select * from example_view where “” = ‘some value’;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants