-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest): drop empty fields #11613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might've been better to rename auto_fix_duplicate_schema_field_paths -> auto_fix_schema_field_paths, and put this functionality in the same method
airflow failure is being fixed here #11616 |
So merging as not related to this PR |
I don’t believe we have that pulled into our ingestion code, will take a look. It looks like that will just drop the field completely from the Schema, that’s not what we want either is it? |
I’d like to understand the empty column name thing - we had assume that that wasn’t really a valid thing (and it also messes up our UI) What’s the use case for it - eg how do you query a table/view with an empty column name? |
I certainly wouldn’t do it but our catalog team doesn’t own the data sets we’re trying to ingest. We have a large number of Snowflake views at our company that have a column with a blank column name here is an example Snowflake SQL to demonstrate: create view example_view as ( select field1 as “”, field2 as “field2” from my_base_table); select * from example_view where “” = ‘some value’; |
Checklist