-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion/snowflake):adds streams as a new dataset with lineage and properties. #12318
Merged
mayurinehate
merged 44 commits into
datahub-project:master
from
brock-acryl:snowflake-streams-v2
Feb 5, 2025
Merged
feat(ingestion/snowflake):adds streams as a new dataset with lineage and properties. #12318
mayurinehate
merged 44 commits into
datahub-project:master
from
brock-acryl:snowflake-streams-v2
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
reviewed
Jan 10, 2025
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_queries.py
Show resolved
Hide resolved
gabe-lyons
reviewed
Jan 10, 2025
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py
Outdated
Show resolved
Hide resolved
c9e611d
to
457f96e
Compare
metadata-ingestion/src/datahub/ingestion/source/sql/sql_config.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_query.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_v2.py
Outdated
Show resolved
Hide resolved
- moved stream lineage from snowflake_v2.py & snowflake_lineage_v2.py to snowflake_schema_gen.py - updated snowflake_schema_gen.py to use snowflake_utils.py
- changed from clone table logic to manually mapping columns since metadata columns were attempting to be mapped from the stream source
… into snowflake-streams-v2 rebase
mayurinehate
requested changes
Jan 29, 2025
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py
Outdated
Show resolved
Hide resolved
…flake_schema_gen.py Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
mayurinehate
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Two pending items:
- update golden files to remove duplicate MCPs due to earlier duplicate yields
- resolve merge conflicts with latest master
mayurinehate
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing, You can run ./gradlew lintFix
to auto-fix lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
ingestion
PR or Issue related to the ingestion of metadata
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Properly picks up: