Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): remove duplicate mcps,more typing #12557

Merged
merged 3 commits into from
Feb 7, 2025
Merged

fix(ingest): remove duplicate mcps,more typing #12557

merged 3 commits into from
Feb 7, 2025

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 5, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...hub/ingestion/source/snowflake/snowflake_schema.py 89.29% <100.00%> (ø)
...ingestion/source/snowflake/snowflake_schema_gen.py 85.96% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d998da...f107e4a. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 5, 2025
hsheth2
hsheth2 approved these changes Feb 5, 2025
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_schema_gen.py Outdated
else [DatasetSubTypes.VIEW]
if isinstance(table, SnowflakeView)
else [DatasetSubTypes.TABLE]
else (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should invert this e.g. SnowflakeStream and SnowflakeView etc have a get_subtype() method

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 5, 2025
@mayurinehate mayurinehate merged commit 180087f into datahub-project:master Feb 7, 2025
189 of 190 checks passed
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 3, 2025
@mayurinehate @shirshanka
fix(ingest): remove duplicate mcps,more typing (datahub-project#12557)
9404b5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @hsheth2