-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest): support pydantic v2 in file-based lineage #12723
Conversation
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We may add some test covering those scenarios in metadata-ingestion/tests/unit/test_file_lineage_source.py
@sgomezvillamor this is actually because of a change in behavior between pydantic v1 and v2. Because all of our tests run with pydantic v1, we can't really test this effectively yet |
Fixes #12623
Checklist