Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): improve error messages for unknown metadata objects #12745

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat(ingest): improve error messages for unknown metadata objects #12745

merged 1 commit into from
Feb 28, 2025

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 27, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 27, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ata-ingestion/src/datahub/ingestion/source/file.py 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 27, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 28, 2025
@hsheth2 hsheth2 merged commit f3b17d4 into master Feb 28, 2025
105 of 134 checks passed
@hsheth2 hsheth2 deleted the mcp-load-error-message branch February 28, 2025 20:37
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 3, 2025
@hsheth2 @shirshanka
feat(ingest): improve error messages for unknown metadata objects (da…
71a86cb 
…tahub-project#12745)
PeteMango pushed a commit to PeteMango/datahub that referenced this pull request Mar 3, 2025
@hsheth2 @PeteMango
feat(ingest): improve error messages for unknown metadata objects (da…
a122909 
…tahub-project#12745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @sgomezvillamor