Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): use uv for python package installs #9885

Merged
merged 25 commits into from
Feb 26, 2024
Merged

feat(ingest): use uv for python package installs #9885

merged 25 commits into from
Feb 26, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Feb 19, 2024 •
edited
Loading

Blocked on astral-sh/uv#1726

Blocked on astral-sh/uv#1787

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Feb 19, 2024
@hsheth2 hsheth2 marked this pull request as draft February 20, 2024 01:28
@hsheth2 hsheth2 mentioned this pull request Feb 20, 2024
Closed
@hsheth2
use uv to generate base requirements
b1a2c05 
with a hot cache, this takes a few seconds vs the minutes that it took before
@hsheth2 hsheth2 marked this pull request as ready for review February 21, 2024 05:48
treff7es
treff7es approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Feb 23, 2024
@hsheth2 hsheth2 merged commit 02f41b7 into master Feb 26, 2024
60 checks passed
@hsheth2 hsheth2 deleted the python-uv-1 branch February 26, 2024 23:02
@hsheth2 hsheth2 mentioned this pull request Feb 27, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es