-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test framework migration #51
Conversation
Approved to run workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes. Rest LGTM !
Thanks @gurjotkaur20
@gurjotkaur20 please keep CRD definitions as it is, i am aware that the manifests get generated automatically. Will work on fixing that. For now, you can copy existing crd definitions. |
Okay. Reverted back the same. |
Improves #42 .
Description
Refactored the tests into Kubebuilder's framework using the gomega and ginkgo
This PR has:
Key changed/added files in this PR
controllers/druid/druid_controller_test.go
controllers/druid/handler_test.go
controllers/druid/suite_test.go
controllers/druid/util_test.go
controllers/druid/zookeeper_dep_mgmt_test.go
go.mod
go.sum