Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test framework migration #51

Merged
merged 7 commits into from
May 4, 2023
Merged

Conversation

gurjotkaur20
Copy link
Contributor

Improves #42 .

Description

Refactored the tests into Kubebuilder's framework using the gomega and ginkgo


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • controllers/druid/druid_controller_test.go
  • controllers/druid/handler_test.go
  • controllers/druid/suite_test.go
  • controllers/druid/util_test.go
  • controllers/druid/zookeeper_dep_mgmt_test.go
  • go.mod
  • go.sum

@AdheipSingh
Copy link
Contributor

Approved to run workflow

Copy link
Contributor

@AdheipSingh AdheipSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes. Rest LGTM !
Thanks @gurjotkaur20

@AdheipSingh
Copy link
Contributor

cc @itamar-marom

@AdheipSingh
Copy link
Contributor

@gurjotkaur20 please keep CRD definitions as it is, i am aware that the manifests get generated automatically. Will work on fixing that. For now, you can copy existing crd definitions.

@gurjotkaur20
Copy link
Contributor Author

@gurjotkaur20 please keep CRD definitions as it is, i am aware that the manifests get generated automatically. Will work on fixing that. For now, you can copy existing crd definitions.

Okay. Reverted back the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants