Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of kubebuilder/kube-rbac-proxy image #94

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Allow configuration of kubebuilder/kube-rbac-proxy image #94

merged 1 commit into from
Aug 17, 2023

Conversation

schmichri
Copy link
Contributor

@schmichri schmichri commented Aug 17, 2023 •
edited
Loading

Description

Allow the configuration of the Containerimage Repository of the kubebuilder/kube-rbac-proxy in case of usage in private kubernetes clusters

This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.
Key changed/added files in this PR
  • chart/Chart.yaml
  • chart/templates/deployment.yaml
  • chart/values.yaml

@AdheipSingh
Copy link
Contributor

cc @itamar-marom

itamar-marom
itamar-marom approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@itamar-marom itamar-marom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdheipSingh AdheipSingh merged commit 1bbee32 into datainfrahq:master Aug 17, 2023
@schmichri
Copy link
Contributor Author

Nice thanks

@schmichri schmichri deleted the helmchart_rbacproxy_registry branch August 17, 2023 17:15
@schmichri
Copy link
Contributor Author

@AdheipSingh When will it be available in Chart Repo?

@AdheipSingh
Copy link
Contributor

@schmichri its done, let me know if you face any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamar-marom itamar-marom itamar-marom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmichri @AdheipSingh @itamar-marom