fix: readiness probe on historical #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyril-corbon
force-pushed
the
fix/historical-probe
branch
2 times, most recently
from
ef25a9d to
5e33880
Compare
itamar-marom
previously approved these changes
Aug 22, 2023
cyril-corbon
force-pushed
the
fix/historical-probe
branch
from
5e33880 to
aabe1b5
Compare
cyril-corbon
force-pushed
the
fix/historical-probe
branch
from
aabe1b5 to
02231f5
Compare
cyril-corbon
dismissed
itamar-marom’s stale review
pr has been modified please take another look
apis/druid/v1alpha1/druid_types.go
Outdated
| // DefaultProbes If set to true this will add default probes (liveness / readiness / startup) for all druid components | ||
| // but it won't override existing probes | ||
| // +optional | ||
| // +kubebuilder:default:=false |
There was a problem hiding this comment.
I think it should be the default unless people want to disable it. Because it should work best "out of the box"
controllers/druid/handler.go
Outdated
| @@ -1143,7 +1143,7 @@ func setLivenessProbe(nodeSpec *v1alpha1.DruidNodeSpec, m *v1alpha1.Druid) *v1.P | |||
| livenessProbe := updateDefaultPortInProbe( | |||
| firstNonNilValue(nodeSpec.LivenessProbe, m.Spec.LivenessProbe).(*v1.Probe), | |||
| nodeSpec.DruidPort) | |||
| if livenessProbe == nil { | |||
| if livenessProbe == nil && m.Spec.DefaultProbes == true { | |||
There was a problem hiding this comment.
you don't need the "== true"
also on the below ones
Signed-off-by: Cyril Corbon <corboncyril@gmail.com>
cyril-corbon
force-pushed
the
fix/historical-probe
branch
from
02231f5 to
cc1018c
Compare
itamar-marom
approved these changes
Aug 23, 2023
yes I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
Description
/druid/historical/v1/readinessBoth path has similar purpose. https://druid.apache.org/docs/latest/operations/api-reference/#historical
This PR has:
Key changed/added files in this PR
controllers/druid/handler.godocs/features.mdchart/templates/crds/druid.apache.org_druids.yamlconfig/crd/bases/druid.apache.org_druids.yaml