-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract LangChain knowledge store to its own module #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e2626d
to
575a699
Compare
126b63d
to
6aee98d
Compare
bjchambers
requested changes
Jun 10, 2024
libs/knowledge-store/ragstack_knowledge_store/knowledge_store.py
Outdated
Show resolved
Hide resolved
libs/knowledge-store/ragstack_knowledge_store/langchain/cassandra.py
Outdated
Show resolved
Hide resolved
libs/knowledge-store/ragstack_knowledge_store/langchain/cassandra.py
Outdated
Show resolved
Hide resolved
libs/knowledge-store/ragstack_knowledge_store/langchain/cassandra.py
Outdated
Show resolved
Hide resolved
b4ff26d
to
42ee615
Compare
bjchambers
approved these changes
Jun 11, 2024
libs/knowledge-store/ragstack_knowledge_store/knowledge_store.py
Outdated
Show resolved
Hide resolved
libs/knowledge-store/ragstack_knowledge_store/knowledge_store.py
Outdated
Show resolved
Hide resolved
libs/knowledge-store/ragstack_knowledge_store/langchain/cassandra.py
Outdated
Show resolved
Hide resolved
ae4ed85
to
e118a58
Compare
e118a58
to
fc7dfbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step.
Next step will be to put it in ragstack-langchain package.