Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) MMR page switch to AstraDBVectorStore (=data api) #474

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

hemidactylus
Copy link
Contributor

The "VectorStore QA with MMR" page is showing usage of the Cassandra vector store class.

This PR switches the page to using the AstraDBVectorStore, i.e. the Data API connector, keeping everything else as it was.
In particular:

  • change in the env vars (endpoint in place of db id)
  • remove note on how to extract db id from endpoint
  • change in the var name for the v.store variable and how it is initialized
  • changes reflected to the separate mmr-example.adoc file.

NOTE the "open in colab" link at the top is still pointing to the Cassandra version of the same workload ... because the code I'm contributing is not hosted as a colab-friendly notebook anywhere. I can add it if desired, but then I'd suggest the location to be a colab/notebook dedicated directory inside this repo (easier maintenance). LMK.

@hemidactylus hemidactylus requested a review from mendonk June 10, 2024 22:00
@cbornet
Copy link
Collaborator

cbornet commented Jun 11, 2024

LGTM.
NIT: lowercase variable names if possible.

hemidactylus and others added 5 commits June 11, 2024 21:26
Co-authored-by: Christophe Bornet <cbornet@hotmail.com>
Co-authored-by: Christophe Bornet <cbornet@hotmail.com>
Co-authored-by: Christophe Bornet <cbornet@hotmail.com>
Co-authored-by: Christophe Bornet <cbornet@hotmail.com>
@hemidactylus hemidactylus merged commit d4fd716 into main Jun 11, 2024
17 checks passed
@hemidactylus hemidactylus deleted the SL-ragstack-mmr-astradbize branch June 11, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants