Ignore forwarding CQL requests for Insights Client #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-antoniak
requested review from
joao-r-reis,
alicel,
grighetto,
absurdfarce and
weideng1
as code owners
alicel
approved these changes
Feb 26, 2025
joao-r-reis
reviewed
Feb 26, 2025
proxy/pkg/zdmproxy/cqlparser.go
Outdated
| @@ -213,13 +214,18 @@ func getRequestInfoFromQueryInfo( | |||
| } | |||
| } else if queryInfo.getStatementType() == statementTypeUse { | |||
| sendAlsoToAsync = true | |||
| } else if queryInfo.getStatementType() == statementTypeCall { | |||
| // RPC client, typically used by "insights reporter" for DSE | |||
There was a problem hiding this comment.
I wonder if it's safer to parse the actual function being called, I'm not sure if there are other RPCs being used with DSE, maybe stuff related to Spark and/or search
There was a problem hiding this comment.
Storing the first identifier would be enough I think? And then check if that identifier matches InsightsRpc (case insensitive to be safe)
There was a problem hiding this comment.
Very good idea. Updated code.
joao-r-reis
reviewed
Feb 26, 2025
proxy/pkg/zdmproxy/cqlparser.go
Outdated
| @@ -213,13 +218,20 @@ func getRequestInfoFromQueryInfo( | |||
| } | |||
| } else if queryInfo.getStatementType() == statementTypeUse { | |||
| sendAlsoToAsync = true | |||
| } else if queryInfo.getStatementType() == statementTypeCall { | |||
| if queryInfo.getCallRpcName() == insightsRpcName { | |||
There was a problem hiding this comment.
should this be a case insensitive comparison? Idk if using CALL insightsrpc work so better be safe than sorry?
joao-r-reis
approved these changes
Feb 26, 2025
|
Very nice stuff 👍 |
lukasz-antoniak
force-pushed
the
insights
branch
from
7822d7f to
449aca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.