Use latest index.json from ivolo/disposable-email-domains instead of manually updating it #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it comes with the latest index.json file, no need to update it manually via the script
…kage removed obsolete src/data/disposable-email-providers.php file
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 100% 100%
- Complexity 58 59 +1
=======================================
Files 17 16 -1
Lines 149 151 +2
=======================================
+ Hits 149 151 +2
Continue to review full report at Codecov.
|
|
This approach makes a lot more sense, thanks for the PR! |
|
You welcome =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the
EmailDataProvider.phpto directly use the index.json file from theivolo/disposable-email-domainspackage. It was added through composer by me and is therefore always available.With this approach you gain 2 advantages:
src/data/disposable-email-providers.phpTests ran without errors on my local machine.
Hope you will welcome this change :)