Track rotation and flipping of OSD viewport #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 74.95% 71.69% -3.27%
==========================================
Files 11 11
Lines 615 643 +28
Branches 184 192 +8
==========================================
Hits 461 461
- Misses 132 156 +24
- Partials 22 26 +4
Continue to review full report at Codecov.
|
stefan-it
reviewed
Jul 30, 2020
jbaiter
force-pushed
the
track-rotation-and-flipping
branch
from
51779c4 to
f8322f6
Compare
morpheus-87
requested changes
Jul 30, 2020
morpheus-87
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #24.
This PR modifies the overlay so it tracks the OSD viewport's rotation and flipping state (used in https://github.com/ProjectMirador/mirador-image-tools):