Improve performance of selection/visibility toggles #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like with opacity and the colors, we can achieve better performance by going around React for these updates. Additionally, we remove the hacky check for the presence of the mirador-image-tools plugin, since it broke once minification/uglification was enabled.
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 71.58% 71.29% -0.29%
==========================================
Files 11 11
Lines 644 648 +4
Branches 194 195 +1
==========================================
+ Hits 461 462 +1
- Misses 156 158 +2
- Partials 27 28 +1
Continue to review full report at Codecov.
|
bitzl
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like with opacity and the colors, we can achieve better performance by going around React for these updates.
Additionally, we remove the hacky check for the presence of the mirador-image-tools plugin, since it broke once minification/uglification was enabled.