-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install postgres-16 in CI #10687
Merged
Merged
install postgres-16 in CI #10687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10687 +/- ##
==========================================
- Coverage 88.92% 88.87% -0.05%
==========================================
Files 180 180
Lines 22785 22785
==========================================
- Hits 20261 20250 -11
- Misses 2524 2535 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
70a1648
to
c071ec8
Compare
c071ec8
to
e9e7948
Compare
e9e7948
to
dda6714
Compare
31214b0
to
e79e981
Compare
03c42ec
to
b4d25fd
Compare
4a6fa32
to
06a3a4a
Compare
1ef3fe6
to
508b45b
Compare
0668a19
to
2ae2f96
Compare
8716a12
to
1982679
Compare
1982679
to
6a2ff56
Compare
6766f52
to
03d9847
Compare
a0fb1fa
to
2519d3c
Compare
2519d3c
to
bf25858
Compare
0ce91a6
to
c8ad9ce
Compare
gshank
approved these changes
Sep 11, 2024
Going to merge this as-is for now, with some follow-up ideas to speed up windows runs:
Issue here: #10696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8286
Problem
We need postgres >= 15 to test dbt-core code that depend on merge operations in dbt-postgres. Specifically this is blocking testing the new microbatch incremental strategy: #10594
Additionally, dbt-postgres is already using postgres 16 in CI so there is some inconsistency there.
Solution
Using: https://computingforgeeks.com/install-and-configure-postgresql-on-ubuntu/
Install postgres 16 onto ubuntu 20.04. We can also consider a service-based approach as what is done in dbt-postgres, but that will likely be a bigger refactor (#10688) + container services are only supported for linux runners. We'd still need to roll our own updates for macos + windows
Checklist