Bugfix: Swap order of datediff input fields in performance timing page view context #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
While doing some debugging on the snowplow performance timing at Grove, I noticed that the jinja for this code was reversed from what the original data model has:
https://github.com/snowplow/snowplow-web-data-model/blob/master/redshift/sql/01-page-views/05-timing-context.sql#L83-L85
The effect of this is that when the three timestamps are 0 (representing ok values) rather than large negative numbers there are large positive numbers. This causes records to be filtered erroneously.
Swapping the order in the datediffs should be enough to resolve the bug.
Checklist