Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the app fails before registering, dbus-broker won't try to start it again #433

Closed
1 of 2 tasks
amezin opened this issue Apr 25, 2023 · 5 comments
Closed
1 of 2 tasks
Assignees
Labels
bug Something isn't working

Comments

@amezin
Copy link
Member

amezin commented Apr 25, 2023

GNOME Shell version

43.4

Session type

Wayland (echo $WAYLAND_DISPLAY output is non-empty)

Special configuration

  • High DPI
  • More than one monitor

ddterm version

44 (pre-release)

Linux distro

Arch Linux

ddterm settings dump

[/]
audible-bell=true
background-color='rgb(23,20,33)'
background-opacity=0.90000000000000002
bold-color='#000000'
bold-color-same-as-fg=true
bold-is-bright=true
command='user-shell'
cursor-background-color='#000000'
cursor-colors-set=false
cursor-foreground-color='#ffffff'
custom-command=''
custom-font='Ubuntu Mono 10'
ddterm-activate-hotkey=@as []
ddterm-toggle-hotkey=['F12']
detect-urls=true
force-x11-gdk-backend=false
foreground-color='rgb(208,207,204)'
hide-animation='linear'
hide-animation-duration=0.14999999999999999
hide-window-on-esc=false
highlight-background-color='#000000'
highlight-colors-set=false
highlight-foreground-color='#ffffff'
new-tab-front-button=true
notebook-border=false
override-window-animation=true
palette=['rgb(23,20,33)', 'rgb(192,28,40)', 'rgb(38,162,105)', 'rgb(162,115,76)', 'rgb(18,72,139)', 'rgb(163,71,186)', 'rgb(42,161,179)', 'rgb(208,207,204)', 'rgb(94,92,100)', 'rgb(246,97,81)', 'rgb(51,209,122)', 'rgb(233,173,12)', 'rgb(42,123,222)', 'rgb(192,97,203)', 'rgb(51,199,222)', 'rgb(255,255,255)']
panel-icon-type='toggle-and-menu-button'
scroll-on-output=false
scrollback-unlimited=true
shortcut-set-custom-tab-title=@as []
shortcut-toggle-maximize=['F11']
shortcut-window-hide=@as []
shortcuts-enabled=true
show-animation='linear'
show-animation-duration=0.14999999999999999
show-scrollbar=true
tab-expand=false
tab-label-width=0.10000000000000001
tab-policy='always'
tab-title-template='{{#if switch-shortcut}}{{switch-shortcut}} {{/if}}{{window-title}}'
theme-variant='dark'
transparent-background=true
use-system-font=true
use-theme-colors=false
window-maximize=false
window-monitor='connector'
window-monitor-connector='eDP-1'
window-position='top'
window-size=0.79947916666666663
window-skip-taskbar=true

Description

During development:

  1. Make some changes to ddterm code and make install
  2. Try to open ddterm. It doesn't start - turns out changes were bad
  3. Fix, make install again
  4. Press F12 and... nothing happens. dbus-broker doesn't try to start ddterm again.

The same will also happen if ddterm fails to start because of missing GObject dependencies (VTE).

However, with dbus-daemon everything works correctly.

@amezin amezin added the bug Something isn't working label Apr 25, 2023
@amezin
Copy link
Member Author

amezin commented Apr 25, 2023

Systemd activation #369 may help mitigating this.

GNOME may sometimes be running without systemd... https://wiki.gentoo.org/wiki/GNOME/GNOME_without_systemd/Gentoo but dbus-broker seems to require systemd for activation

@amezin amezin self-assigned this Apr 25, 2023
@amezin
Copy link
Member Author

amezin commented Apr 25, 2023

Something related bus1/dbus-broker#209

@amezin amezin changed the title If the app fails before registering, D-Bus daemon won't try to start it again If the app fails before registering, dbus-broker won't try to start it again Apr 26, 2023
@amezin
Copy link
Member Author

amezin commented May 27, 2023

Systemd activation solves this issue for dbus-broker...
But now dbus-daemon can't detect the failure properly - systemd unit fails to start, but dbus-daemon only detects it by timeout (2 minutes)

@amezin
Copy link
Member Author

amezin commented May 29, 2023

So dbus-daemon can't detect failures for systemd activation:

Check the type of session dbus daemon and avoid systemd activation for dbus-daemon? This is becoming too complex

@amezin
Copy link
Member Author

amezin commented May 29, 2023

On the other hand, 2 minute timeout with dbus-daemon+systemd activation looks better than seemingly forever with dbus-broker and no systemd unit.

amezin added a commit that referenced this issue May 29, 2023
amezin added a commit that referenced this issue May 29, 2023
amezin added a commit that referenced this issue May 30, 2023
amezin added a commit that referenced this issue May 30, 2023
amezin added a commit that referenced this issue May 30, 2023
amezin added a commit that referenced this issue May 30, 2023
@amezin amezin closed this as completed in 590ec21 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant