Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical Debt - Need refactor in dkg & shuffler #220

Closed
chenchanglew opened this issue Nov 23, 2022 · 0 comments · Fixed by #243
Closed

Technical Debt - Need refactor in dkg & shuffler #220

chenchanglew opened this issue Nov 23, 2022 · 0 comments · Fixed by #243
Assignees
@chenchanglew
Labels
dkg shuffling

Comments

@chenchanglew
Copy link
Contributor

chenchanglew commented Nov 23, 2022 •
edited
Loading

Some parts of the code need to rewrite to increase its readability

Where:
services/dkg/pedersen/handler.go handleDecryptRequest() Line 505-519
services/shuffle/neff/handler.go handleStartShufflt() Line 134-148

Target:
all the unit tests in dkg should pass.
all the unit tests in shuffling should pass.
all the functions should be able to work as before.
@chenchanglew chenchanglew self-assigned this Nov 23, 2022
@chenchanglew chenchanglew changed the title Refactor - dkg Refactor - dkg & shuffler Nov 23, 2022
@chenchanglew chenchanglew changed the title Refactor - dkg & shuffler TechDebt - Need refactor in dkg & shuffler Dec 21, 2022
@chenchanglew chenchanglew linked a pull request Dec 21, 2022 that will close this issue
Solve tech debt, refactor the flow to increase readability #243
Merged
@chenchanglew chenchanglew changed the title TechDebt - Need refactor in dkg & shuffler Techical Debt - Need refactor in dkg & shuffler Jan 4, 2023
@chenchanglew chenchanglew changed the title Techical Debt - Need refactor in dkg & shuffler Technical Debt - Need refactor in dkg & shuffler Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenchanglew chenchanglew

Labels
dkg shuffling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solve tech debt, refactor the flow to increase readability dedis/d-voting
1 participant
@chenchanglew