Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve tech debt, refactor the flow to increase readability #243

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Solve tech debt, refactor the flow to increase readability #243

merged 1 commit into from
Dec 22, 2022

Conversation

chenchanglew
Copy link
Contributor

Where:
Services/dkg/pedersen/handler.go
Services/shuffler/neff/handler.go

How:
refactor to make the logic more clear

@chenchanglew chenchanglew requested a review from a team as a code owner December 21, 2022 11:30
@chenchanglew chenchanglew linked an issue Dec 21, 2022 that may be closed by this pull request
Technical Debt - Need refactor in dkg & shuffler #220
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3748890079

  • 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 56.768%
Changes Missing Coverage Covered Lines Changed/Added Lines %
services/dkg/pedersen/handler.go 2 4 50.0%
services/shuffle/neff/handler.go 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 3 87.21%
Totals Coverage Status
Change from base Build 3744679039: -0.07%
Covered Lines: 3271
Relevant Lines: 5762
💛 - Coveralls

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@chenchanglew chenchanglew merged commit b055918 into main Dec 22, 2022
@chenchanglew chenchanglew deleted the 220-refactor-dkg-shuffler branch December 22, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcr nkcr nkcr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Technical Debt - Need refactor in dkg & shuffler
3 participants
@chenchanglew @coveralls @nkcr